Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching issue in golangci-lint GitHub action #2223

Closed
dejanzele opened this issue Mar 6, 2023 · 3 comments
Closed

Fix caching issue in golangci-lint GitHub action #2223

dejanzele opened this issue Mar 6, 2023 · 3 comments

Comments

@dejanzele
Copy link
Member

dejanzele commented Mar 6, 2023

Without caching enabled in golangci-lint GitHub Actions job, it takes around 5 minutes to lint Golang code.
The golangci-lint action supports caching, but has an intermitent issue mentioned here - golangci/golangci-lint-action#244

Currently caching is disabled in our Lint job with the following lines - https://github.com/armadaproject/armada/blob/master/.github/workflows/go.yml#L32-L33

Either find a way how to run the action with caching enabled deterministically, or create a PR with a fix in https://github.com/golangci/golangci-lint-action

┆Issue is synchronized with this Jira Task by Unito

@dave-gantenbein
Copy link
Member

@dave-gantenbein
Copy link
Member

@Sharpz7
Copy link
Contributor

Sharpz7 commented Aug 24, 2023

Closing - I doubt this is relevant since Dejans changes CI changes

@Sharpz7 Sharpz7 closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants