Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching issue in golangci-lint GitHub action #138

Closed
sync-by-unito bot opened this issue Apr 7, 2023 · 2 comments
Closed

Fix caching issue in golangci-lint GitHub action #138

sync-by-unito bot opened this issue Apr 7, 2023 · 2 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 7, 2023

Without caching enabled in golangci-lint GitHub Actions job, it takes around 5 minutes to lint Golang code.
The golangci-lint action supports caching, but has an intermitent issue mentioned here - golangci/golangci-lint-action#244

Currently caching is disabled in our Lint job with the following lines - https://github.com/armadaproject/armada/blob/master/.github/workflows/go.yml#L32-L33

Either find a way how to run the action with caching enabled deterministically, or create a PR with a fix in https://github.com/golangci/golangci-lint-action

┆Issue is synchronized with this Jira Task by Unito

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 7, 2023

➤ Dave Gantenbein commented:

Hey team! Please add your planning poker estimate ( https://app.zenhub.com/workspaces/Armada-62c744dc3b819100132ca032/issues/armadaproject/armada/2223?planning-poker ) with Zenhub dejanzele kannon92 richscott Sharpz7 suprjinx

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 7, 2023

➤ Dave Gantenbein commented:

Hey team! Please add your planning poker estimate ( https://app.zenhub.com/workspaces/Armada-62c744dc3b819100132ca032/issues/armadaproject/armada/2223?planning-poker ) with Zenhub ClifHouck dejanzele headphonejames kannon92 richscott Sharpz7 suprjinx

@sync-by-unito sync-by-unito bot closed this as completed Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants