Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Protocol imports on >=3.10 #134

Merged

Conversation

FasterSpeeding
Copy link
Contributor

@FasterSpeeding FasterSpeeding commented Jan 3, 2023

Description

Since typing_extensions is only required on >3.10, attempts to run the latest release on <=3.10 fail if typing_extensions hasn't been installed into the target environment.

Protocol was added to the std typing module in 3.8 so this should only ever need to fallback to typing_extensions for Protocol on 3.7 and some 3.8 alpha releases.

I don't know why your CI is installing typing_extensions before running tests on 3.10 and 3.11.

Before merge

  • tox runs successfully
  • Docs updated

Before release (if applicable)

  • Version updated in pyproject.toml
  • Version updated in pre-commit hook example
  • Version updated in changelog
  • Branch merged
  • Tag created and pushed
  • Published

@ariebovenberg
Copy link
Owner

Thanks! I can handle the release from here. It probably didn't trigger any build failure due to typing-extensions being a test dependency 🤔

@ariebovenberg ariebovenberg merged commit e80825a into ariebovenberg:main Jan 3, 2023
@ariebovenberg
Copy link
Owner

@FasterSpeeding release 0.16.3 is now out with your fix 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants