Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since typing_extensions is only required on >3.10, attempts to run the latest release on <=3.10 fail if typing_extensions hasn't been installed into the target environment.
Protocol was added to the std
typing
module in 3.8 so this should only ever need to fallback to typing_extensions for Protocol on 3.7 and some 3.8 alpha releases.I don't know why your CI is installing typing_extensions before running tests on 3.10 and 3.11.
Before merge
tox
runs successfullyBefore release (if applicable)
pyproject.toml