fix: use correct node name as args to PodName. Fixes #9906

[isubasinghe]

Signed-off-by: Isitha Subasinghe isitha@pipekit.io

Fixes #9906

Please do not open a pull request until you have checked ALL of these:

• Create the PR as draft .
• Run make pre-commit -B to fix codegen and lint problems.
• Sign-off your commits (otherwise the DCO check will fail).
• Use a conventional commit message (otherwise the commit message check will fail).
• "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
• Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
• Github checks are green.
• Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

[isubasinghe]

The issue was with the PodName function, the name doesn't suggest this but it generates names for you using a hash of the fields.
PodName was called with the name+formatting applied to it, resulting in a different Hash.

This is the simplest fix, but I personally think it would be nicer if two functions existed. A GeneratePodName and GetPodName. This way the generation is more obvious.

[isubasinghe]

Here is the working argo get command

[mweibel]

is there a possibility to release this as a bugfix soon?

[caelan-io]

@mweibel yes, we're looking at a new 3.4.4 patch release in the near future.