Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assume plugins may produce outputs.result and outputs.exitCode (Fixes #9966) #9967

Merged
merged 2 commits into from Nov 4, 2022

Conversation

crenshaw-dev
Copy link
Contributor

@crenshaw-dev crenshaw-dev commented Nov 4, 2022

Fixes #9966

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Contributor Author

crenshaw-dev commented Nov 4, 2022

Getting the following error from make pre-commit -B:

k8s.io/apimachinery/pkg/runtime/schema/generated.proto: File not found

I'm gonna ignore that because I'm 99.9% sure I don't need codegen.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev marked this pull request as ready for review November 4, 2022 13:17
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terrytangyuan terrytangyuan merged commit d4e60fa into argoproj:master Nov 4, 2022
@crenshaw-dev crenshaw-dev deleted the plugins-have-outputs branch November 6, 2022 00:15
sarabala1979 pushed a commit that referenced this pull request Nov 29, 2022
…ixes #9966) (#9967)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot reference plugin's output parameters
2 participants