Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleaned key paths in gcs driver. Fixes #9958 #9959

Merged
merged 1 commit into from Nov 4, 2022

Conversation

isubasinghe
Copy link
Member

@isubasinghe isubasinghe commented Nov 3, 2022

Signed-off-by: Isitha Subasinghe isitha@pipekit.io

Fixes #9958

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@isubasinghe isubasinghe marked this pull request as ready for review November 3, 2022 12:42
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@terrytangyuan terrytangyuan merged commit 6ba1fa5 into argoproj:master Nov 4, 2022
@JPZ13 JPZ13 mentioned this pull request Nov 8, 2022
sarabala1979 pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCS Artifact path handling does not normalise the path.
2 participants