Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show pending workflows in workflow list Fixes #9812 #9909

Merged

Conversation

isubasinghe
Copy link
Member

@isubasinghe isubasinghe commented Oct 26, 2022

Signed-off-by: Isitha Subasinghe isitha@pipekit.io

Fixes #9812

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@isubasinghe isubasinghe marked this pull request as ready for review October 30, 2022 06:38
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@terrytangyuan terrytangyuan merged commit 4c6b6bf into argoproj:master Nov 1, 2022
Radolumbo pushed a commit to Radolumbo/argo-workflows that referenced this pull request Nov 2, 2022
…oproj#9909)

Signed-off-by: Nick Palumbo <npalumbo8@bloomberg.net>
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflows in the Pending state that are waiting for the mutex are not showing in the UI
3 participants