fix: mount secret with SSE-C key if needed, fix secret key read. Fixes #9867 #9870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
github.com/argoproj/pkg
once fix: add missing ServerSideEncryption param in GetDirectory. pkg#225 si merged and releasedFixes #9867
Adds mount of the SSE-C secret, if SSE-C is configured. Fixed the secret key used when reading the SSE-C key. Adds unit test to validate the mounts. Also tested inside a different project, where Argo and another component both read/write SSE-C encrypted objects from/to AWS S3.
Please do not open a pull request until you have checked ALL of these:
make pre-commit -B
to fix codegen and lint problems.If changes were requested, and you've made them, dismiss the review to get it reviewed again.