Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mount secret with SSE-C key if needed, fix secret key read. Fixes #9867 #9870

Merged
merged 2 commits into from Nov 3, 2022

Conversation

michal-raska
Copy link
Contributor

@michal-raska michal-raska commented Oct 20, 2022

TODO:

Fixes #9867

Adds mount of the SSE-C secret, if SSE-C is configured. Fixed the secret key used when reading the SSE-C key. Adds unit test to validate the mounts. Also tested inside a different project, where Argo and another component both read/write SSE-C encrypted objects from/to AWS S3.

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Michal Raška <michal.raska@h2o.ai>
@michal-raska michal-raska changed the title fix(9867): mount secret with SSE-C key if needed, fix secret key read Fixes #9867: mount secret with SSE-C key if needed, fix secret key read Oct 20, 2022
@michal-raska michal-raska changed the title Fixes #9867: mount secret with SSE-C key if needed, fix secret key read fix: mount secret with SSE-C key if needed, fix secret key read. Fixes #9867 Oct 20, 2022
@michal-raska michal-raska marked this pull request as ready for review November 2, 2022 08:31
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tczhao
Copy link
Member

tczhao commented Nov 3, 2022

Hi @aaronmell , Could have a look at this PR?

@tczhao tczhao requested a review from alexec November 3, 2022 00:10
Copy link
Contributor

@aaronmell aaronmell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't have write access to the Repo though, so I can't approve

@terrytangyuan terrytangyuan merged commit b91606a into argoproj:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSE-C secret not mounted
4 participants