fix(test): skip artifact private repo test. Fixes: #8953 #9838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibotdotout
changed the title
ibotdotout
force-pushed
the
skip-private-repo
branch
from
ce8f1e1
to
40a9da4
Compare
ibotdotout
changed the title
I see then how about just update document and git hook pre-commit message. Let me know if you have another suggestion. |
alexec
reviewed
Oct 18, 2022
docs/running-locally.md
Outdated
| @@ -199,6 +199,7 @@ Before you commit code and raise a PR, always run: | |||
|
|
|||
| ```bash | |||
| make pre-commit -B | |||
| CI=true make test | |||
There was a problem hiding this comment.
This is wrong? CI should be false/unset unless on CI.
There was a problem hiding this comment.
Agreed, just try to skip the test.
So, updated to skip it directly as you mentioned in #8953.
ibotdotout
force-pushed
the
skip-private-repo
branch
from
f4b2e8f
to
793527b
Compare
ibotdotout
changed the title
ibotdotout
requested review from
alexec
and removed request for
terrytangyuan
| @@ -25,6 +25,10 @@ func TestGitArtifactDriver_Load(t *testing.T) { | |||
| assert.DirExists(t, path) | |||
| }) | |||
| t.Run("PrivateRepo", func(t *testing.T) { | |||
|
|
|||
| // TODO: temp - skip private repo test for everyone | |||
There was a problem hiding this comment.
why do you want to skip this test?
There was a problem hiding this comment.
As @alexec mentioned here
#8953 (comment)
alexec
approved these changes
Oct 29, 2022
Signed-off-by: ibotdotout <tkroputa@gmail.com>
auto-merge was automatically disabled
October 31, 2022 04:26
Head branch was pushed to by a user without write access
ibotdotout
force-pushed
the
skip-private-repo
branch
from
3340b75
to
a4a3c33
Compare
ibotdotout
requested review from
terrytangyuan and
sarabala1979
and removed request for
terrytangyuan
|
Could you help to merge ? |
terrytangyuan
approved these changes
Nov 2, 2022
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
…oproj#9838) Signed-off-by: ibotdotout <tkroputa@gmail.com> Signed-off-by: juchao <juchao@coscene.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8953
IntroducedSKIP_PRIVATE_REPOenvironment variable to skipTestGitArtifactDriver_Load PrivateRepotest that some contributors lack of private repo access.Update test to skip
TestGitArtifactDriver_Load PrivateRepo.Please do not open a pull request until you have checked ALL of these:
make pre-commit -Bto fix codegen and lint problems.If changes were requested, and you've made them, dismiss the review to get it reviewed again.