Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.2.9 Cherry-pick #8043

Closed
sarabala1979 opened this issue Mar 1, 2022 · 5 comments
Closed

v3.2.9 Cherry-pick #8043

sarabala1979 opened this issue Mar 1, 2022 · 5 comments
Projects
Run The Business (incl. bugs)

Comments

@sarabala1979
Copy link
Member

sarabala1979 commented Mar 1, 2022 •
edited

Planning to release v3.2.9 end of today. Please select your issues which you want to include in this release
@sarabala1979 sarabala1979 added type/feature Feature request and removed type/feature Feature request labels Mar 1, 2022
@alexec
Copy link
Contributor

alexec commented Mar 1, 2022

@sarabala1979 can I request

  • only show fixes in list, not chore/feat
  • I think some of these fixes are already in v3.2?

@sarabala1979
Copy link
Member Author

done. issues have fix subject that's why it is included. I will do a manual check next time.
I got PRs from last hash in v3.2 to master HEAD.

@alexec
Copy link
Contributor

alexec commented Mar 1, 2022

Can I leave it with you to review the list and include any bug fixes you think we need?

@sarabala1979
Copy link
Member Author

sure

@alexec alexec added this to Backlog in Run The Business (incl. bugs) via automation Mar 2, 2022
@alexec
Copy link
Contributor

alexec commented Mar 2, 2022 •
edited

CI build is broken:

test-functional:

Error: test/e2e/semaphore_test.go:79:18: too many arguments in call to s.E2ESuite.Given().Workflow("@functional/synchronization-tmpl-level-mutex-semaphore.yaml").When().CreateConfigMap
[15](https://github.com/argoproj/argo-workflows/runs/5385554814?check_suite_focus=true#step:17:15)
	have (string, map[string]string, map[string]string)
[16](https://github.com/argoproj/argo-workflows/runs/5385554814?check_suite_focus=true#step:17:16)
	want (string, map[string]string)
[17](https://github.com/argoproj/argo-workflows/runs/5385554814?check_suite_focus=true#step:17:17)
FAIL	github.com/argoproj/argo-workflows/v3/test/e2e [build failed]

test-examples:

VERIFICATION
[11052](https://github.com/argoproj/argo-workflows/runs/5385554895?check_suite_focus=true#step:17:11052)
make: *** [Makefile:497: test-examples] Error 1
[11053](https://github.com/argoproj/argo-workflows/runs/5385554895?check_suite_focus=true#step:17:11053)
✖ http-template-bfkpq: AssertionError

lint

Running [/home/runner/golangci-lint-1.42.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
[74](https://github.com/argoproj/argo-workflows/runs/5385655918?check_suite_focus=true#step:4:74)
  Error: too many arguments (typecheck)
[73](https://github.com/argoproj/argo-workflows/runs/5385655918?check_suite_focus=true#step:4:73)
  Running [/home/runner/golangci-lint-1.42.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
[74](https://github.com/argoproj/argo-workflows/runs/5385655918?check_suite_focus=true#step:4:74)
  Error: too many arguments (typecheck)

@alexec alexec moved this from Backlog to In progress in Run The Business (incl. bugs) Mar 2, 2022
Run The Business (incl. bugs) automation moved this from In progress to Done Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Run The Business (incl. bugs)
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexec @sarabala1979