Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to clone repository with submodule url git@github.com #7469

Closed
66li opened this issue Dec 24, 2021 · 13 comments · Fixed by #8225
Closed

Unable to clone repository with submodule url git@github.com #7469

66li opened this issue Dec 24, 2021 · 13 comments · Fixed by #8225
Labels
area/executor type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@66li
Copy link
Contributor

66li commented Dec 24, 2021

Bugs in the new version of go-git

Same as this problem description, it can be avoided by rolling back to version 3.4
go-git/go-git#397

@sarabala1979
Copy link
Member

will wait go-git resolution go-git/go-git#397

@alexec
Copy link
Contributor

alexec commented Feb 2, 2022

fix: Relative submodules in git artifacts. Fixes #7141 (#7162)

@alexec alexec added area/executor type/regression Regression from previous behavior (a specific type of bug) labels Feb 2, 2022
@Hunter-Thompson
Copy link
Contributor

I created a PR on go-github, lets wait and see. Hoping to get it merged ASAP since this bug breaks SSH cloning.

go-git/go-git#464

@alexec alexec added the blocked label Feb 21, 2022
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Mar 2, 2022
@Hunter-Thompson
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

keep

@stale stale bot removed the problem/stale This has not had a response in some time label Mar 2, 2022
@stale
Copy link

stale bot commented Mar 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Mar 12, 2022
@Hunter-Thompson
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Keep

@stale stale bot removed the problem/stale This has not had a response in some time label Mar 12, 2022
@Harishkrishna17
Copy link

@Hunter-Thompson Any update on this ?
Is there any workaround available

@Hunter-Thompson
Copy link
Contributor

@Hunter-Thompson Any update on this ? Is there any workaround available

There is no work around, Id suggest going back to v3.2.4

@Harishkrishna17
Copy link

Rolling back to 3.2.4 causes the ssh issue for checkout of code from GitHub .

Issue :

You're using an RSA key with sha-1 , which is no longer allowed , please user a newer client or a different key type

alexec pushed a commit that referenced this issue Mar 24, 2022
* fix: submodule cloning via git. Fixes #7469

Signed-off-by: Hunter-Thompson <aatman@auroville.org.in>

* chore: add smallcase to USERS.md

Signed-off-by: Hunter-Thompson <aatman@auroville.org.in>

* chore: move into require block

Signed-off-by: Hunter-Thompson <aatman@auroville.org.in>
@Harishkrishna17
Copy link

When is this pr going to be released ? any tentative date ?
Thanks

@tcolgate
Copy link
Contributor

tcolgate commented Apr 8, 2022

Can the go-git version being used not be rolled back within argo? This is a really painful break. I've spotted the merging of the forked version on master. Is there any chance that fix could be backported to a v3.3 point release? I'm working on migrating off of the docker executor and am basing that work on v3.3, but can't run it if this bug persists, (docker executor is slated to be removed in v3.4)

@tcolgate
Copy link
Contributor

tcolgate commented Apr 12, 2022

I've cherry picked 1d373c4 into 3.3.1 and rebuilt my executor image. The original "url can't contain colon" message has gone, but pulling the submodule still fails:

time="2022-04-12T07:08:53.994Z" level=error msg="executor error: artifact code failed to load: pkt-line 1: invalid hash text: encoding/hex: invalid byte: U+0052 'R' (ERR \n  myorg/myrepo.git/myorgl/mysubmod is not a valid repository name\n  Visit https://support.github.com/ for help)"

@sarabala1979 sarabala1979 mentioned this issue Apr 14, 2022
85 tasks
sarabala1979 pushed a commit that referenced this issue Apr 18, 2022
* fix: submodule cloning via git. Fixes #7469

Signed-off-by: Hunter-Thompson <aatman@auroville.org.in>

* chore: add smallcase to USERS.md

Signed-off-by: Hunter-Thompson <aatman@auroville.org.in>

* chore: move into require block

Signed-off-by: Hunter-Thompson <aatman@auroville.org.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/executor type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants