Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.2.4 cherry-pick #7171

Closed
4 of 25 tasks
sarabala1979 opened this issue Nov 4, 2021 · 18 comments
Closed
4 of 25 tasks

v3.2.4 cherry-pick #7171

sarabala1979 opened this issue Nov 4, 2021 · 18 comments
Assignees
@alexec
Labels
type/feature Feature request
Projects
Run The Business (incl. bugs)

Comments

@sarabala1979
Copy link
Member

sarabala1979 commented Nov 4, 2021 •
edited by alexec

@sarabala1979 sarabala1979 added the type/feature Feature request label Nov 4, 2021
@iulianionita-ai
Copy link

Could you, please include in 3.2.4 #7084 ?

@yasselavila
Copy link

Please, if you can include #7084 it would be very nice. Thanks

@sarabala1979
Copy link
Member Author

sarabala1979 commented Nov 5, 2021 via email

@book987
Copy link
Contributor

book987 commented Nov 5, 2021

Hi, Could you please include #6912 ? Thanks

@alexec
Copy link
Contributor

alexec commented Nov 5, 2021

Please add:

Bob Haddleton: fix(executor): add test for non-root user creating a script ( fix(executor): change script file permissions to 0o644 and add test for non-root user creating a script #6905) 73d6010

@alexec
Copy link
Contributor

alexec commented Nov 5, 2021

@sarabala1979 I think we should make, for patch release, all fixes are always added.

@simster7
Copy link
Member

simster7 commented Nov 5, 2021

@sarabala1979 Any reason why only commits made before Oct 27 are included in this?

@alexec
Copy link
Contributor

alexec commented Nov 5, 2021 •
edited

@sarabala1979 I think we might want an updated list? I get a different list of fixes:

git log v3.2.3..origin/master --oneline --grep 'fix.*:'

f347154 (HEAD -> master, origin/master) fix: add gh ecdsa and ed25519 to known hosts (#7226)
eb9a428 fix: Fix ANSI color sequences escaping (#7211)
1453edc fix: Do not patch empty progress. fixes #7184 (#7204)
34e5b54 fix: ci sleep command syntax for macOS 12 (#7203)
17fb9d8 fix: allow wf templates without parameter values (Fixes #6044) (#7124)
225a5a3 fix(test): Make TestMonitorProgress Faster (#7185)
0482964 fix(ui): Correctly show zero-state when CRDs not installed. Fixes #7001 (#7169)
f9e554d fix: Relative submodules in git artifacts. Fixes #7141 (#7162)
22af736 fix: Reorder CI checks so required checks run first (#7142)
bd3be11 fix: Return error when YAML submission is invalid (#7135)
209ff9d fix: Respect template.HTTP.timeoutSeconds (#7136)
02165aa fix(controller): default volume/mount to emissary (#7125)
3d59726 fix: typo in node-field-selector.md (#7116)
ca87f29 fix: Daemon step in running state, but dependents don't start (#7107)
1e87159 fix: Add pod name format annotation. Fixes #6962 and #6989 (#6982)
c5de76b fix: Format issue on WorkflowEventBinding parameters. Fixes #7042 (#7087)
64fce4a fix: Ensure HTTP reconciliation occurs for onExit nodes (#7084)
d6a62c3 fix: Ensure HTTP templates have children assigned (#7082)
46767b8 fix(ui): Correct HTTP connection in pipeline view (#7077)
201ba55 fix: add outputs.parameters scope to script/containerSet templates. Fixes #6439 (#7045)
31bf57b fix: Unit test TestNewOperation order of pipeline execution maybe different to order of submit (#7069)
4734cbc fix: Precedence of ContainerRuntimeExecutor and ContainerRuntimeExecutors (#7056)
65ff89a fix: Memozie for Step and DAG level (#7028)
0baa4a2 fix: Support RFC3339 in creationTimeStamp. Fixes #6906 (#7044)
ba472e1 fix: Minor corrections to Swagger/JSON schema (#7027)
3f0a531 fix(controller): use correct pod.name in retry/podspecpatch scenario. Fixes #7007 (#7008)
7f52623 fix(ui): labels in report/archive should be sorted (#7009)
50813da fix(controller): fix bugs in processing retry node output parameters. Fixes #6948 (#6956)
86ddda5 fix: Restore default pod name version to v1 (#6998)
0446f52 fix(artifact)!: default https to any URL missing a scheme. Fixes #6973 (#6985)
cfdebf6 fix(typo): correct typo in event-dispatch error log (#6688)
2a15853 fix: OAuth2 callback with self-signed Root CA. Fixes #6793 (#6978)
72356ab fix: Allow self-signed Root CA for SSO. Fixes #6793 (#6961)
c705294 fix: response on canceled workflow action (#6859) (#6967)
cf9a6cd fix: Unreachable code in util/tls/tls.go. Fixes #6950 (#6960)
6e1f250 fix: multi-steps workflow (#6957)
4524339 fix(docs): fix data transformation example (#6901)
73d6010 fix(executor): add test for non-root user creating a script (#6905)
79d03a9 fix: Skip empty withParam tasks. Fixes #6834 (#6912)
67fe87b fix(ui): Change pod names to new format. Fixes #6865 (#6925)
1bcfa1a fix: BASE_HREF ignore (#6926)
41515d6 fix(controller): Fix getPodByNode, TestGetPodByNode. Fixes #6458 (#6897)
5a7708c fix: do not delete expr tag tmpl values. Fixes #6909 (#6921)
ef6aad6 fix: Parameter with Value and Default (#6887)
4d38404 fix: Resource requests on init/wait containers. Fixes #6809 (#6879)
cca4792 fix(ui): fixed width button (#6883)
c962bb1 fix: upgrade sprig to v3.2.2 (#6876)

@sarabala1979
Copy link
Member Author

@sarabala1979 I think we might want an updated list? I get a different list of fixes:

git log v3.2.3..origin/master --oneline --grep 'fix.*:'

0482964 fix(ui): Correctly show zero-state when CRDs not installed. Fixes #7001 (#7169) f9e554d fix: Relative submodules in git artifacts. Fixes #7141 (#7162) 22af736 fix: Reorder CI checks so required checks run first (#7142) bd3be11 fix: Return error when YAML submission is invalid (#7135) 209ff9d fix: Respect template.HTTP.timeoutSeconds (#7136) 02165aa fix(controller): default volume/mount to emissary (#7125) 3d59726 fix: typo in node-field-selector.md (#7116) ca87f29 fix: Daemon step in running state, but dependents don't start (#7107) 1e87159 fix: Add pod name format annotation. Fixes #6962 and #6989 (#6982) c5de76b fix: Format issue on WorkflowEventBinding parameters. Fixes #7042 (#7087) 64fce4a fix: Ensure HTTP reconciliation occurs for onExit nodes (#7084) d6a62c3 fix: Ensure HTTP templates have children assigned (#7082) 46767b8 fix(ui): Correct HTTP connection in pipeline view (#7077) 201ba55 fix: add outputs.parameters scope to script/containerSet templates. Fixes #6439 (#7045) 31bf57b fix: Unit test TestNewOperation order of pipeline execution maybe different to order of submit (#7069) 4734cbc fix: Precedence of ContainerRuntimeExecutor and ContainerRuntimeExecutors (#7056) 65ff89a fix: Memozie for Step and DAG level (#7028) 0baa4a2 fix: Support RFC3339 in creationTimeStamp. Fixes #6906 (#7044) ba472e1 fix: Minor corrections to Swagger/JSON schema (#7027) 3f0a531 fix(controller): use correct pod.name in retry/podspecpatch scenario. Fixes #7007 (#7008) 7f52623 fix(ui): labels in report/archive should be sorted (#7009) 50813da fix(controller): fix bugs in processing retry node output parameters. Fixes #6948 (#6956) 86ddda5 fix: Restore default pod name version to v1 (#6998) 0446f52 fix(artifact)!: default https to any URL missing a scheme. Fixes #6973 (#6985) cfdebf6 fix(typo): correct typo in event-dispatch error log (#6688) 2a15853 fix: OAuth2 callback with self-signed Root CA. Fixes #6793 (#6978) 72356ab fix: Allow self-signed Root CA for SSO. Fixes #6793 (#6961) c705294 fix: response on canceled workflow action (#6859) (#6967) cf9a6cd fix: Unreachable code in util/tls/tls.go. Fixes #6950 (#6960) 6e1f250 fix: multi-steps workflow (#6957) 4524339 fix(docs): fix data transformation example (#6901) 73d6010 fix(executor): add test for non-root user creating a script (#6905) 79d03a9 fix: Skip empty withParam tasks. Fixes #6834 (#6912) 67fe87b fix(ui): Change pod names to new format. Fixes #6865 (#6925) 1bcfa1a fix: BASE_HREF ignore (#6926) 41515d6 fix(controller): Fix getPodByNode, TestGetPodByNode. Fixes #6458 (#6897) 5a7708c fix: do not delete expr tag tmpl values. Fixes #6909 (#6921) ef6aad6 fix: Parameter with Value and Default (#6887) 4d38404 fix: Resource requests on init/wait containers. Fixes #6809 (#6879) cca4792 fix(ui): fixed width button (#6883) c962bb1 fix: upgrade sprig to v3.2.2 (#6876)

Agreed as long as fix doesn't have new upcoming feature changes/dependency

@sarabala1979
Copy link
Member Author

sarabala1979 commented Nov 9, 2021 •
edited by simster7

@sarabala1979
Copy link
Member Author

@alexec I think 3.2 we will follow the cherry pick way. after 3.3 onwards we will merge all fixes (appropriates) to patch release instead of pick and choose.

@valorl
Copy link
Contributor

valorl commented Nov 12, 2021 •
edited

Could you please clarify whether #6905 will be included ? It's in @alexec's list but I don't see it in the new checklist. It's blocking us from trying 3.2 features, so would be nice if possible 🙂

@sarabala1979
Copy link
Member Author

sarabala1979 commented Nov 12, 2021 via email

@sarabala1979
Copy link
Member Author

sarabala1979 commented Nov 12, 2021 •
edited

@alexec alexec self-assigned this Nov 17, 2021
@alexec alexec added this to To do in Run The Business (incl. bugs) via automation Nov 17, 2021
@alexec alexec moved this from To do to In progress in Run The Business (incl. bugs) Nov 17, 2021
@mitchellgordon95
Copy link

Is it too late to get #6995 in? it's been a couple weeks and it would definitely help me out.

@alexec
Copy link
Contributor

alexec commented Nov 17, 2021

We don't normally back port features I'm afraid.

@kostas-theo
Copy link
Contributor

Hi @alexec - This issue is still opened and 3.2.4 has been released. Are the listed items still slated to be included in the next release?

@alexec alexec closed this as completed Nov 22, 2021
@alexec
Copy link
Contributor

alexec commented Nov 22, 2021 •
edited

Please see changelog.

@sarabala1979 sarabala1979 moved this from In progress to Done in Run The Business (incl. bugs) Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/feature Feature request
Projects
Run The Business (incl. bugs)
Done
Milestone
No milestone
Development

No branches or pull requests
9 participants
@simster7 @yasselavila @alexec @mitchellgordon95 @valorl @book987 @sarabala1979 @kostas-theo @iulianionita-ai