@agilgur5 Could you help me to look at this issue, Thanks!

Could you explain or give examples of when this is a problem please?

Could you explain or give examples of when this is a problem please?

The logic of the first piece of code is to send a kubectl exec command using spdy protocol and get its return value.
When the return value is fetched, it blocks and waits for the stdout and stderr value to complete. see this code
https://github.com/kubernetes/client-go/blob/4ebe42d8c9c18f464fcc7b4f15b3a632db4cbdb2/tools/remotecommand/v4.go#L54-L76

It's going to block down here. In some unusual cases, the goroutine gets stuck here forever. if all the pod clean up workers are block here, something very serious will happen.

https://github.com/kubernetes/client-go/blob/4ebe42d8c9c18f464fcc7b4f15b3a632db4cbdb2/tools/remotecommand/v4.go#L67-L72

@Joibel You can read what I just commented on. Thank you!

@Joibel This is already happening in our internal test environment. All pod cleanup workers are blocked, preventing pods from being cleaned.

I can see that these might block, and that your fix fixes this.
I'm surprised you're seeing a problem though, and suspect you must have some other issue and that this fix is just going to mask that other problem.
Do you know why you're seeing this on your test environment?
Is there something unusual about what you're doing in the pods that are getting stuck?
Are the nodes they are on being terminated, are they producing a LOT of logs?
Is there intermittent connectivity?
Why do you think that other people don't have this issue? We know lots of users who have high workloads and their controllers can run for weeks or months without problems.

Is there intermittent connectivity?
Why do you think that other people don't have this issue? We know lots of users who have high workloads and their controllers can run for weeks or months without problems.

@Joibel Thanks for your review, This is to execute a kill -15 command, the kill command log is very few and the kill command does not block. I guess it's because there's a problem connecting multiple proxys, but I can't find out why because the pod has actually been cleaned, So I think we need to prevent this from happening, I think this is a very good improvement to optimize the prevention of this kind of situation, what do you think?

First of all, maybe no one have noticed this problem, but this problem was discovered by users in the kubernetes community, so he added the ability to cancel the commit, for details you can see this link kubernetes/kubernetes#103177

Second, I think this is a good optimization point, and we should make some preventive improvements in this code.