Fix: Enable users to use Archived Workflows functionality when RBAC is Namespace delegated #10399
+566
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
juliev0
commented
Jan 25, 2023
| } | ||
| message ListArchivedWorkflowLabelValuesRequest { | ||
| k8s.io.apimachinery.pkg.apis.meta.v1.ListOptions listOptions = 1; | ||
| string namespace = 2; | ||
| } |
There was a problem hiding this comment.
I wasn't absolutely sure whether to add namespace to these last two. These seem to be used for populating the drop downs. The requests themselves don't need that information, but I figured if somebody has selected a user namespace this will allow them to get this information in the case of namespace-delegated RBAC.
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
…mespace Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
alexec
approved these changes
Jan 31, 2023
jessesuen
reviewed
Jan 31, 2023
jessesuen
pushed a commit
to akuity/argo-workflows
that referenced
this pull request
Jan 31, 2023
…s Namespace delegated (argoproj#10399) Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com>
reddymh
pushed a commit
to reddymh/argo-workflows
that referenced
this pull request
Jan 31, 2023
…s Namespace delegated (argoproj#10399) Signed-off-by: Julie Vogelmani <julie_vogelman@intuit.com> Signed-off-by: Rajshekar Reddy <reddymh@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8498
Implementation is based on the recommendations by Jesse here. Each archives request (not just "list") now includes a namespace parameter, and implements GetNamespace(), enabling the existing gateway functionality to locate the right Service Account based on the caller's claims.
For backward compatibility with existing client libraries, the existing field selector method of selecting namespace is also supported.