Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Skip blocked Workflow execution #10396

Closed
nasa9084 opened this issue Jan 25, 2023 · 1 comment
Closed

Feature Request: Skip blocked Workflow execution #10396

nasa9084 opened this issue Jan 25, 2023 · 1 comment
Labels
area/mutex-semaphore solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/feature Feature request

Comments

@nasa9084
Copy link

Summary

When a Workflow execution is blocked because of semaphore or mutex, we want to skip the blocked Workflow instead of current wait&run

Use Cases

We're using ArgoEvents to submit a Workflow from WorkflowTemplate (and in our case, this is time-based so maybe the same thing can be said for CronWorkflow but we don't use it so not sure).
Sometimes, a Workflow execution takes longer than the period we're configuring in the cron setting. In such cases, we want to cancel the second execution (which will be blocked to be run until the first one completes).

For example, assume a Workflow that will be executed once an hour by ArgoEvents and now is 00:00. The Workflow is limited to be run just once at the same time, using semaphore or mutex.
First, a Workflow execution for 00:00 will be submitted and it takes 1.5 hours long to complete the task. Then next Workflow execution for 01:00 will be submitted but the 00:00 one is still running so blocked due to semaphore or mutex. We want to cancel/skip this 01:00 one and want to expect the 02:00 one, but with the current implementation, the 01:00 one will be executed at 01:30 and the 02:00 one will be blocked.

So here's a feature request: Adding an option not to execute the Workflow when the Workflow is blocked because of semaphore or mutex.


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@agilgur5
Copy link
Member

Going to close this out as superseded by #13055 as it has a concrete proposal that could handle more use-cases

@agilgur5 agilgur5 added the solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mutex-semaphore solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants