Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct behaviour of CreateBucketIfNotPresent. Fixes #10083 #10084

Merged
merged 2 commits into from Nov 25, 2022
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Nov 21, 2022

Signed-off-by: Alex Collins alex_collins@intuit.com

Fixes #10083

I'm extremely surprised no one has raised a bug about this before. Makes me suspicious.

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Copy link
Contributor Author

alexec commented Nov 21, 2022

@alexcapras you originally authored this feature in 2020. Could I please ask for your review.

@alexec
Copy link
Contributor Author

alexec commented Nov 21, 2022

I expect that @alexcapras is unlikely to be able to review this. Authors of historic commits have usually moved on.

@alexcapras
Copy link
Contributor

@alexcapras you originally authored this feature in 2020. Could I please ask for your review.

Lgtm @alexec - thank you for addressing

@alexec alexec marked this pull request as ready for review November 21, 2022 18:57
@alexec alexec enabled auto-merge (squash) November 21, 2022 18:57
@alexec alexec merged commit be759b4 into master Nov 25, 2022
@alexec alexec deleted the s3 branch November 25, 2022 03:09
@agilgur5 agilgur5 added the area/artifacts S3/GCP/OSS/Git/HDFS etc label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make E2E test suite re-runnable (TestOutputArtifactS3BucketCreationEnabled)
5 participants