Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make E2E test suite re-runnable (TestOutputArtifactS3BucketCreationEnabled) #10083

Closed
3 tasks done
alexec opened this issue Nov 21, 2022 · 1 comment · Fixed by #10084
Closed
3 tasks done

Make E2E test suite re-runnable (TestOutputArtifactS3BucketCreationEnabled) #10083

alexec opened this issue Nov 21, 2022 · 1 comment · Fixed by #10084
Assignees
Labels
area/build Build or GithubAction/CI issues P3 Low priority type/bug type/tech-debt

Comments

@alexec
Copy link
Contributor

alexec commented Nov 21, 2022

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

One of the tests in the E2E cannot be re-run, that means the retry in the CI build cannot re-run it.

Version

master

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

=== PASS: FunctionalSuite/TestOptionalInputArtifacts
[2161](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2162)
=== RUN   TestFunctionalSuite/TestOutputArtifactS3BucketCreationEnabled
[2162](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2163)
Submitting workflow  output-artifact-with-s3-bucket-creation-enabled-
[2163](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2164)
Waiting 1m0s for workflow metadata.name=output-artifact-with-s3-bucket-creation-enabled-2sckw
[2164](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2165)
 ? output-artifact-with-s3-bucket-creation-enabled-2sckw Workflow 0s      
[2165](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2166)

[2166](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2167)
 ● output-artifact-with-s3-bucket-creation-enabled-2sckw   Workflow  0s      
[2167](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2168)
 └ ● output-artifact-with-s3-bucket-creation-enabled-2sckw Steps     0s      
[2168](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2169)
 └ ◷ generate-artifact                                     Pod       0s      
[2169](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2170)
 └ ● [0]                                                   StepGroup 0s      
[2170](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2171)

[2171](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2172)
 ● output-artifact-with-s3-bucket-creation-enabled-2sckw   Workflow  0s      
[2172](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2173)
 └ ● output-artifact-with-s3-bucket-creation-enabled-2sckw Steps     0s      
[2173](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2174)
 └ ◷ generate-artifact                                     Pod       0s      PodInitializing
[2174](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2175)
 └ ● [0]                                                   StepGroup 0s      
[2175](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2176)

[2176](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2177)
 ● output-artifact-with-s3-bucket-creation-enabled-2sckw   Workflow  0s      
[2177](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2178)
 └ ● output-artifact-with-s3-bucket-creation-enabled-2sckw Steps     0s      
[2178](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2179)
 └ ● generate-artifact                                     Pod       0s      
[2179](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2180)
 └ ● [0]                                                   StepGroup 0s      
[2180](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2181)

[2181](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2182)
 ✖ output-artifact-with-s3-bucket-creation-enabled-2sckw   Workflow  9s      child 'output-artifact-with-s3-bucket-creation-enabled-2sckw-1722879605' failed
[2182](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2183)
 └ ✖ output-artifact-with-s3-bucket-creation-enabled-2sckw Steps     9s      child 'output-artifact-with-s3-bucket-creation-enabled-2sckw-1722879605' failed
[2183](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2184)
 └ ⚠ generate-artifact                                     Pod       4s      Error (exit code 1): failed to create bucket bucket-that-does-not-exist-2: Your previous request to create the named bucket succeeded and you already own it.
[2184](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2185)
 └ ✖ [0]                                                   StepGroup 9s      child 'output-artifact-with-s3-bucket-creation-enabled-2sckw-1722879605' failed
[2185](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2186)

[2186](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2187)
    functional_test.go:879: condition never and cannot be met because the workflow is done
[2187](https://github.com/argoproj/argo-workflows/actions/runs/3515513837/jobs/5890991633#step:17:2188)
=== FAIL: FunctionalSuite/TestOutputArtifactS3BucketCreationEnabled
@alexec alexec self-assigned this Nov 21, 2022
@alexec alexec changed the title Make E2E test suite re-runnable Make E2E test suite re-runnable (TestOutputArtifactS3BucketCreationEnabled) Nov 21, 2022
@alexec
Copy link
Contributor Author

alexec commented Nov 21, 2022

Ah. This is actually a bug with CreateBucketIfNotPresent. If the bucket already exists, it fails. Which is should not.

@alexcapras FYI

alexec added a commit that referenced this issue Nov 21, 2022
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 added the P3 Low priority label Nov 21, 2022
alexec added a commit that referenced this issue Nov 25, 2022
…10084)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@agilgur5 agilgur5 added type/tech-debt area/build Build or GithubAction/CI issues labels Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues P3 Low priority type/bug type/tech-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants