Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): search artifact by uid in archived wf. Fixes #9968 #10014

Merged

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Nov 11, 2022

Fixes #9968

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@tczhao tczhao changed the title fix(ui): search artifact by uid in archived wf fix(ui): search artifact by uid in archived wf. Fixes #9968 Nov 11, 2022
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@tczhao tczhao marked this pull request as ready for review November 11, 2022 03:37
@terrytangyuan terrytangyuan merged commit e2e1f16 into argoproj:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to download Artifacts from the Archived Workflows UI (v3.4.3)
3 participants