Manual retries do not trigger exit handlers

[pquadri]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

When defining a workflow that has an exit handler (either with handlers or lifecycle hooks) a manual retry of the workflow does not trigger a rerun of the handler unless the handler himself fails, while in the code there is a comment that clearly states that the handler should always be executed.
I will soon test it on the latest version, but the code that causes the problem hasn't changed recently.

Version

3.4.1

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: retry-script-
spec:
  entrypoint: retry-script
  hooks:
    exit:
      template: handler
      arguments:
        parameters:
          - name: message
            value: "{{ workflow.status }}"

  templates:
  - name: retry-script
    script:
      image: python:alpine3.6
      command: ["python"]
      source: |
        import random;
        import sys; 
        exit_code = 1; 
        sys.exit(exit_code)
  - name: handler
    inputs: 
      parameters: 
        - name: message 
    container:
      image: alpine:latest
      command: [sh, -c]
      args: ["echo {{inputs.parameters.message}}"]

Logs from the workflow controller

---

Logs from in your workflow's wait container

---

[pquadri]

i'm afraid i did not actually fix it despite the test passing, the exit handler group is rescheduled for execution but its steps are not, there is definetly something I am missing in the groups reset logic

[terrytangyuan]

Would you like to take another look?

[pquadri]

I will try but I'm not sure how to check it honestly, will do what I can :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

[pquadri]

the issue should be solved in the new linked pr :)