fix: avoid closing and re-opening port of api server settings change #9778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #9778 +/- ##
==========================================
- Coverage 45.81% 45.78% -0.03%
==========================================
Files 227 227
Lines 26882 26904 +22
==========================================
+ Hits 12315 12318 +3
- Misses 12891 12908 +17
- Partials 1676 1678 +2
Continue to review full report at Codecov.
|
alexmt
added a commit
that referenced
this pull request
Jun 24, 2022
…9778) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
crenshaw-dev
added
the
cherry-pick/2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Closes #5742
API server restarts listeners and closes/reopens grpc connection (for grpc-gateway) on every dex/oidc related setting change that causes issues in production. The PR changes the behavior to avoid restarting listeners and only re-create server handlers.