fix: respect OIDC providers' supported token signing algorithms (#9433) #9761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proj#9433) Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Codecov Report
@@ Coverage Diff @@
## master #9761 +/- ##
==========================================
+ Coverage 45.85% 45.90% +0.04%
==========================================
Files 227 227
Lines 26795 26795
==========================================
+ Hits 12286 12299 +13
+ Misses 12840 12820 -20
- Partials 1669 1676 +7
Continue to review full report at Codecov.
|
zachaller
approved these changes
Jun 22, 2022
crenshaw-dev
added
cherry-pick/2.4
crenshaw-dev
added a commit
that referenced
this pull request
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades our go-oidc version to 2.2.1, which allows us to support the token signing algorithm advertised by the OIDC provider. (See the pull request on go-oidc.)
Fixes #9433