Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/remote: Allow override of base image #9734

Merged
merged 1 commit into from Jun 21, 2022

Conversation

yselkowitz
Copy link
Contributor

ubuntu:22.04 bumped the ppc64el baseline to POWER9, rendering this unusable on existing POWER8 systems. This allows customization similar to the top-level Dockerfile.

Please cherry-pick to 2.4 as well.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

/cc @jannfis

@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Jun 21, 2022
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) June 21, 2022 15:47
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #9734 (06f75a8) into master (a0ec77e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9734   +/-   ##
=======================================
  Coverage   45.85%   45.85%           
=======================================
  Files         226      226           
  Lines       26795    26795           
=======================================
  Hits        12286    12286           
  Misses      12840    12840           
  Partials     1669     1669           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ec77e...06f75a8. Read the comment docs.

@alexmt
Copy link
Collaborator

alexmt commented Jun 21, 2022

Can you please merge master branch changes to pull in CI fix?

ubuntu:22.04 bumped the ppc64el baseline to POWER9, rendering this
unusable on existing POWER8 systems.  This allows customization similar
to the top-level Dockerfile.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
auto-merge was automatically disabled June 21, 2022 18:23

Head branch was pushed to by a user without write access

@alexmt alexmt enabled auto-merge (squash) June 21, 2022 18:24
@alexmt alexmt merged commit 2b53716 into argoproj:master Jun 21, 2022
@yselkowitz yselkowitz deleted the test-remote branch June 21, 2022 19:23
crenshaw-dev pushed a commit that referenced this pull request Jun 21, 2022
ubuntu:22.04 bumped the ppc64el baseline to POWER9, rendering this
unusable on existing POWER8 systems.  This allows customization similar
to the top-level Dockerfile.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
@crenshaw-dev
Copy link
Collaborator

Cherry-picked onto release-2.4 for release in 2.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants