fix: updated config file permission requirements for windows (#9666) #9732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
…pdate_windows_permissions
Codecov Report
@@ Coverage Diff @@
## master #9732 +/- ##
=======================================
Coverage 45.85% 45.85%
=======================================
Files 226 227 +1
Lines 26795 26795
=======================================
Hits 12286 12286
Misses 12840 12840
Partials 1669 1669
Continue to review full report at Codecov.
|
…pdate_windows_permissions
crenshaw-dev
requested changes
Jun 21, 2022
| @@ -1,3 +1,5 @@ | |||
| //go:build !windows | |||
There was a problem hiding this comment.
Can we have an equivalent test for windows?
There was a problem hiding this comment.
From Slack:
I actually did try to create windows only tests but I just couldn't manage to set the permission properly with golang it just won't set it to something other than 0444 or 0666
lgtm. :-)
crenshaw-dev
approved these changes
Jun 21, 2022
alexmt
added
the
cherry-pick/2.4
|
PR fixes v2.4 regression. Adding cherry-pick label. |
crenshaw-dev
changed the title
crenshaw-dev
pushed a commit
that referenced
this pull request
Jun 21, 2022
* fix: reduced config file permission restriction on windows Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * fix: updated localconfig tests to check error Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
|
Cherry-picked onto release-2.4 for release with 2.4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9666
Fixes #9702
This PR updates the permission requirements for windows to 0444 or 0666 instead of 0400 and 0600. The config file produced by argocd cli on windows always appears to be having 0666 permission this is probably due to some limitations on windows acl, hence this PR updates the requirement specifically for windows for 0666 or 0444 permission instead of 0400/0600.
Checklist: