Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

below spelling wrong #9687

Merged
merged 1 commit into from Jun 16, 2022
Merged

below spelling wrong #9687

merged 1 commit into from Jun 16, 2022

Conversation

hritikch24
Copy link
Contributor

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #9687 (ee8228d) into master (91de2f3) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9687      +/-   ##
==========================================
- Coverage   45.86%   45.78%   -0.09%     
==========================================
  Files         226      226              
  Lines       26676    26688      +12     
==========================================
- Hits        12234    12218      -16     
- Misses      12779    12807      +28     
  Partials     1663     1663              
Impacted Files Coverage Δ
server/application/websocket.go 8.33% <0.00%> (-4.57%) ⬇️
server/application/logs.go 82.45% <0.00%> (-3.26%) ⬇️
pkg/apiclient/apiclient.go 0.38% <0.00%> (-1.25%) ⬇️
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
...is/applicationset/v1alpha1/applicationset_types.go 36.95% <0.00%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91de2f3...ee8228d. Read the comment docs.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) June 16, 2022 14:08
@crenshaw-dev crenshaw-dev merged commit 5c4e38a into argoproj:master Jun 16, 2022
crenshaw-dev pushed a commit that referenced this pull request Jun 21, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Jun 21, 2022
@crenshaw-dev
Copy link
Collaborator

Cherry-picked onto release-2.4 for 2.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants