Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken symlink in dockerfile #9672 #9674

Merged
merged 1 commit into from Jun 21, 2022
Merged

fix: fix broken symlink in dockerfile #9672 #9674

merged 1 commit into from Jun 21, 2022

Conversation

JorenZ
Copy link
Contributor

@JorenZ JorenZ commented Jun 15, 2022

Fixes #9672

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them. N/A
  • Does this PR require documentation updates? No.
  • I've updated documentation as required by this PR. N/A
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged. N/A
  • My build is green (troubleshooting builds).

Signed-off-by: Joren Zandstra <jorenzandstra@yahoo.com>
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #9674 (e4a963b) into master (56eb095) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9674   +/-   ##
=======================================
  Coverage   45.85%   45.85%           
=======================================
  Files         226      226           
  Lines       26675    26675           
=======================================
  Hits        12231    12231           
  Misses      12783    12783           
  Partials     1661     1661           
Impacted Files Coverage Δ
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56eb095...e4a963b. Read the comment docs.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @JorenZ
LGTM

@34fathombelow
Copy link
Member

Nice catch! LGTM

@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Jun 17, 2022
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev merged commit 9b41c08 into argoproj:master Jun 21, 2022
crenshaw-dev pushed a commit that referenced this pull request Jun 21, 2022
Signed-off-by: Joren Zandstra <jorenzandstra@yahoo.com>
@crenshaw-dev
Copy link
Collaborator

Cherry-picked onto release-2.4 for 2.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD Dockerfile contains broken symlink (/app/config/ssh/ssh_known_hosts)
4 participants