Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project filter is not applied to refreshing applications from other projects #9651

Closed
3 tasks done
romachalm opened this issue Jun 14, 2022 · 4 comments · Fixed by #9709
Closed
3 tasks done

Project filter is not applied to refreshing applications from other projects #9651

romachalm opened this issue Jun 14, 2022 · 4 comments · Fixed by #9709
Assignees
Labels
bug Something isn't working cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch component:ui User interfaces bugs and enhancements

Comments

@romachalm
Copy link
Contributor

romachalm commented Jun 14, 2022

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

When I apply a projects filter on applications, the applications are correctly filtered. But each time an application from another project gets its status updated (progressing for instance), it appears in the list of the filtered applications,

When I refresh the page, the list is reverted with the correct filter until the changing applications start appearing in the list.

I haven't seen this behaviour with cluster filter nor namespace filter.

To Reproduce

You need to have several applications from several projects

  • Apply a project filter
  • Wait until an app from another project has its status changed and watch it dynamically appearing in the list of filtered applications

Expected behavior

Once the project filter is applied, no application from another project should be listed
Screenshots

Version

v2.4.0+91aefab

Logs

@romachalm romachalm added the bug Something isn't working label Jun 14, 2022
@crenshaw-dev crenshaw-dev added the component:ui User interfaces bugs and enhancements label Jun 14, 2022
@saumeya
Copy link
Contributor

saumeya commented Jun 14, 2022

The project filter is implemented on the server side unlike the other filters - #8102

@djfinnoy
Copy link
Contributor

djfinnoy commented Jun 15, 2022

I think this applies to apps that are refreshing as well. I'm seeing apps from other projects come and go, even though the UI is indicating that they are synced and healthy.

Problem first appeared after upgrading to v2.4.0

Edit:
I've not actually managed to catch any of the unfiltered apps in a refreshing state. Not sure what's causing them to circumvent filters, but it looks like something deeper than just status changes.

@romachalm
Copy link
Contributor Author

I confirm : refreshing apps from other projects appears in the filtered list, whatever the actual status of the application is.

@rphua
Copy link

rphua commented Jun 15, 2022

I can confirm this is also the case for our team this happened after v.2.4.0

Problem first appeared after upgrading to v2.4.0

@romachalm romachalm changed the title Project filter is not applied on applications with status changing from other projects Project filter is not applied to refreshing applications from other projects Jun 15, 2022
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Jun 15, 2022
@keithchong keithchong self-assigned this Jun 17, 2022
keithchong added a commit to keithchong/argo-cd that referenced this issue Jun 17, 2022
crenshaw-dev added a commit to crenshaw-dev/argo-cd that referenced this issue Jun 17, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
crenshaw-dev added a commit that referenced this issue Jun 17, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
crenshaw-dev added a commit that referenced this issue Jun 21, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch component:ui User interfaces bugs and enhancements
Projects
None yet
6 participants