Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add custom health checks for astra.netapp.io CRDs #17998 #17999

Merged
merged 1 commit into from May 1, 2024
Merged

feat: Add custom health checks for astra.netapp.io CRDs #17998 #17999

merged 1 commit into from May 1, 2024

Conversation

MichaelHaigh
Copy link
Contributor

@MichaelHaigh MichaelHaigh commented Apr 26, 2024 •
edited

Fixes #17998

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@MichaelHaigh
Adding astra.netapp.io CRD health checks
7c1e2f8 
Signed-off-by: Michael Haigh <mhaigh@netapp.com>
@MichaelHaigh MichaelHaigh requested a review from a team as a code owner April 26, 2024 16:58
todaywasawesome
todaywasawesome approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I don't generally test these because I view it as the provider's responsibility.

@pasha-codefresh pasha-codefresh merged commit 220dee0 into argoproj:master May 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom health checks for astra.netapp.io CRDs
3 participants
@MichaelHaigh @todaywasawesome @pasha-codefresh