Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display revisions when generating a badge for a multi-source application #17986

Open
2 of 3 tasks
nbarrientos opened this issue Apr 26, 2024 · 0 comments
Open
2 of 3 tasks
Labels
bug Something isn't working component:api API bugs and enhancements multi-source-apps Bugs or enhancements related to multi-source Applications.

Comments

@nbarrientos
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

badge.go does not take into account multi-source applications when determining the revision to display on a badge. It only extracts the value from app.Status.OperationState.SyncResult.Revision, leaving app.Status.OperationState.SyncResult.Revisions behind.

Example multi-source application object dumped via the API:

image

To Reproduce

Crate a multi-source application and generate a the badge passing revision=true. No revision is added.

Expected behavior

Revisions from sources are added to the badge.

Screenshots

n/a

Version

v2.10.7

Logs

n/a

@nbarrientos nbarrientos added the bug Something isn't working label Apr 26, 2024
@ishitasequeira ishitasequeira added multi-source-apps Bugs or enhancements related to multi-source Applications. component:api API bugs and enhancements labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:api API bugs and enhancements multi-source-apps Bugs or enhancements related to multi-source Applications.
Projects
None yet
Development

No branches or pull requests

2 participants