Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to reload argocd-server config or restart pods after removing data.oidc.config from argocd-cm. #12221

Closed
jameshearttech opened this issue Jan 31, 2023 · 6 comments
Labels
bug Something isn't working type:usability Enhancement of an existing feature

Comments

@jameshearttech
Copy link

Describe the bug

After removing data.oidc.config from argocd-cm argocd-server is not updated. I discovered this when switching from native OIDC to Dex. The Dex config was updated by adding data.dex.config, but the native OIDC was still doing authorization using old data.oidc.config.

To Reproduce

Have not attempted to reproduce.

Expected behavior

The configuration of argocd-server should be updated after data.oidc.config is removed from argocd-cm through a config reloader or whatever mechanism is in use or the pods should be restarted.

Screenshots
image
image
image
image

Version

$ argocd version
argocd: v2.5.6+9db2c94
  BuildDate: 2023-01-10T19:55:00Z
  GitCommit: 9db2c9471f6ff599c3f630b446e940d3a065620b
  GitTreeState: clean
  GoVersion: go1.18.9
  Compiler: gc
  Platform: linux/amd64
argocd-server: v2.5.9+e5f1194
  BuildDate: 2023-01-27T23:27:14Z
  GitCommit: e5f1194a6de78cc1124179a4c9bb1ae3484fb77d
  GitTreeState: clean
  GoVersion: go1.18.10
  Compiler: gc
  Platform: linux/amd64
  Kustomize Version: v4.5.7 2022-08-02T16:35:54Z
  Helm Version: v3.10.3+g835b733
  Kubectl Version: v0.24.2
  Jsonnet Version: v0.18.0

Logs

  • See screenshots.
@jameshearttech jameshearttech added the bug Something isn't working label Jan 31, 2023
@nikos445
Copy link

nikos445 commented Feb 6, 2023

Almost same issue here...
I get errors like:

  • Error while dialing dial tcp: lookup argocd-repo-server argocd
  • time="2023-02-06T21:34:38Z" level=warning msg="Failed to save clusters info: dial tcp 10.100.78.107:6379: i/o timeout" argocd

Tried:

  • Restarting all pods together.. doesn't fix problem..
  • Redeploying...

TEMPORARY SOLUTION:

  • I need to restart argocd-redis and argocd-repo-server in sequence... meaning that
  • I need to restart all pods and then restart redis after all pods seem healthy and then restart repo-server after redis is again healthy.

Same issue as this..

https://stackoverflow.com/questions/73276522/argocd-transport-error-while-dialing-dial-tcp-lookup-argocd-repo-server

And this...

https://stackoverflow.com/questions/70120083/not-able-to-connect-argocd-with-gitlab-repository

NOTE: IT IS NOT A DNS ISSUE... I Tested and Verified everything 1000%

Also please consider that Redis is seem healthy but it does not respond...

My ArgoCD Deployment Details:

{
    "Version": "v2.6.0+acc554f",
    "BuildDate": "2023-02-06T21:17:26Z",
    "GitCommit": "acc554f3d99010e0353b498a595844b30090556f",
    "GitTreeState": "clean",
    "GoVersion": "go1.18.10",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v4.5.7 2022-08-02T16:35:54Z",
    "HelmVersion": "v3.10.3+g835b733",
    "KubectlVersion": "v0.24.2",
    "JsonnetVersion": "v0.19.1"
}

Kubernetes info:

Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.1", GitCommit:"8f94681cd294aa8cfd3407b8191f6c70214973a4", GitTreeState:"clean", BuildDate:"2023-01-18T15:58:16Z", GoVersion:"go1.19.5", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.1", GitCommit:"8f94681cd294aa8cfd3407b8191f6c70214973a4", GitTreeState:"clean", BuildDate:"2023-01-18T15:51:25Z", GoVersion:"go1.19.5", Compiler:"gc", Platform:"linux/amd64"}

@jessesuen
Copy link
Member

Hot-reload of configmap changes has been flakey/broken for some time. There were attempts to fix it, but they ended up being insufficient.

Related: #10707

Workaround is to restart argocd-server pods ATM.

@jessesuen jessesuen added the type:usability Enhancement of an existing feature label Feb 9, 2023
@drpaneas
Copy link
Contributor

drpaneas commented Mar 2, 2023

This issue should be fixed by now, thx to #12076 being merged.

@jameshearttech
Copy link
Author

@drpaneas I'll go ahead and close it.

@blakepettersson
Copy link
Member

I'm not sure #12076 will fix this issue, since that PR is related to reloading of the certificate rather than the reloading of configmaps 🤔

@drpaneas
Copy link
Contributor

drpaneas commented Mar 3, 2023

@blakepettersson might be, yes.
@jameshearttech when you have the time for it, let us know if this is still an issue, and by all means feel free to re-open this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working type:usability Enhancement of an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants