Warning when there are no plugins supported given repo #15338
rozdestvenskiy
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
When there are no plugins supported given repo, cmp gives an error and application marked as failed. Also its fail of sync and application doesnt create anything from manifest.
But should it be an error? Why not to do it like a warning?
For example: we use argocd-vault-plugin in application set. But not every app in this set contains templates for vault. And these apps marked as failed and we cant get their resources.
Now its here: https://github.com/argoproj/argo-cd/blob/master/util/app/discovery/discovery.go (line 119)
if !connFound { return nil, nil, fmt.Errorf("could not find plugin supporting the given repository") }
Maybe its better to do it like:
if !connFound { return nil, nil, fmt.Sprintf("could not find plugin supporting the given repository") }
Beta Was this translation helpful? Give feedback.
All reactions