Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Include SHA of test merge commit in PR generator for GitHub #623

Open
purajit opened this issue Feb 24, 2023 · 0 comments
Open

Include SHA of test merge commit in PR generator for GitHub #623

purajit opened this issue Feb 24, 2023 · 0 comments

Comments

@purajit
Copy link

purajit commented Feb 24, 2023

Component: Pull Request Generator

Request: Currently, when using the PR Generator with GitHub, we are provided with the head_sha. Additionally being provided with merge_commit_sha would be extremely useful.

Motivation: The default behavior of a lot of widely-used GHAs, such as actions/checkout and docker/metadata-action, is to use the test merge commit sha rather than the head sha. Providing this value would mean users have a way of working with PR generator without having to override this behavior throughout their stack, and seeing predicatable values being propagated everywhere.

I'm unfamiliar with GitLab and Gitea but I think based on some quick searching that they too create test merge commits, but at least for GH, it seems like it would require a change

Other links:
MergeCommitSHA in the GitHub client
Argo docs for template and params
Information about test merge commit SHA and how it changes

@purajit purajit changed the title Include merge_commit_sha in PR generator for GitHub Include SHA of test merge commit in PR generator for GitHub Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant