Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for repositories in gitlab subgroups. (was: Add rhio-LIS2HH12 library) #53

Open
JoseMartiRhombio opened this issue Jun 26, 2020 · 4 comments
Assignees
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@JoseMartiRhombio
Copy link

Hello,

rhomb.io have developed a LIS2HH12 library to run this accelerometer
Please, could you add the https://gitlab.com/rhombio/rhio-LIS2HH12 to the Library Manager?

Thanks

@cmaglie
Copy link
Member

cmaglie commented Jun 30, 2020

Done.

@cmaglie cmaglie closed this as completed Jun 30, 2020
@JoseMartiRhombio
Copy link
Author

JoseMartiRhombio commented Jul 2, 2020

Done.

Excuse me @cmaglie , I have needed to change the url, could you update the information with this url; https://gitlab.com/rhombio/rhio-libraries/rhio-LIS2HH12 ? The new version is v0.1.1

@per1234 per1234 reopened this Jul 2, 2020
@cmaglie
Copy link
Member

cmaglie commented Jul 7, 2020

The "subgroups" feature of gitlab requires us to implement a special handling on our library indexer. I think this is a quite new feature of gitlab since until now we assumed that the path was always in the form: http://gitlab.com/USERNAME/REPOSITORY

BTW I see that gitlab redirects from the old URL to the new URL transparently so things should just work in your particular case.

About the missing v0.1.1, the problem is not the changed repo URL but the version written in library.properties:

https://gitlab.com/rhombio/rhio-libraries/rhio-LIS2HH12/-/blob/v0.1.1/library.properties

as you can see the file still has version=0.1.0. BTW on master I see 0.1.1 so I guess you pushed the tag before updating the version on master. To fix this just delete the tag 0.1.1 and redo it on master`

I'll keep this issue open until we add support for gitlab's "subgroutp" on the library indexer.

@cmaglie cmaglie changed the title Add rhio-LIS2HH12 library Add support for repositories in gitlab subgroups. (was: Add rhio-LIS2HH12 library) Nov 18, 2020
@arduino arduino deleted a comment from kbkibbe Dec 9, 2020
@JoseMartiRhombio
Copy link
Author

JoseMartiRhombio commented Jan 20, 2021 via email

@per1234 per1234 transferred this issue from arduino/Arduino Jun 12, 2021
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Jun 12, 2021
@per1234 per1234 self-assigned this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

3 participants