Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent failure of "arduino-stats" GitHub Actions workflow runs #971

Closed
3 tasks done
per1234 opened this issue Apr 26, 2022 · 0 comments 路 Fixed by #1603
Closed
3 tasks done

Persistent failure of "arduino-stats" GitHub Actions workflow runs #971

per1234 opened this issue Apr 26, 2022 · 0 comments 路 Fixed by #1603
Assignees
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Apr 26, 2022

Describe the problem

The "arduino-stats" GitHub Actions workflow was designed to periodically gather download statistics from Arduino's CDN and push them to Datadog.

馃悰 On 2022-03-14, the runs of the "arduino-stats" GitHub Actions workflow began to fail:

Traceback (most recent call last):
  File "/home/runner/work/arduino-ide/arduino-ide/.github/tools/fetch_athena_stats.py", line 127, in <module>
    exec_id = execute(athena_client, query, DEST_S3_OUTPUT)
  File "/home/runner/work/arduino-ide/arduino-ide/.github/tools/fetch_athena_stats.py", line 27, in execute
    wait_for_query_execution_completion(client, execution_id)
  File "/home/runner/work/arduino-ide/arduino-ide/.github/tools/fetch_athena_stats.py", line 40, in wait_for_query_execution_completion
    raise BaseException(
BaseException: query failed or canceled: INVALID_FUNCTION_ARGUMENT: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: "b "

Because there had not been any relevant change in the repository between the last successful run and the first failing run, it seems likely that some external change caused the breakage.

To reproduce

  1. Open the workflow runs list for the "arduino-stats" workflow: https://github.com/arduino/arduino-ide/actions/workflows/arduino-stats.yaml
  2. Note the status of the runs.

馃悰 They have all failed since 2022-03-14

Expected behavior

All workflows in the repository to be useful and in a functional state.

Additional context

The same problem happened with the workflow in the Arduino CLI repository. Since that workflow was not ever working correctly (I don't have any idea whether the one in this repo ever did) and the lack of an investigation about that indicates that the stats are not of immediate importance, it was decided the best course of action was to simply remove the broken infrastructure from the repository rather than investing time into fixing something that isn't being used anyway: arduino/arduino-cli#1701

The companion "github-stats" workflow, although functional, was removed as not valuable on its own at the same time: arduino/arduino-cli#1702

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Apr 26, 2022
@per1234 per1234 assigned davegarthsimpson and unassigned fstasi Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants