Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gRPC downloads cancelable by complying to context.Context done signaling. #2595

Closed
3 of 5 tasks
cmaglie opened this issue May 6, 2024 · 0 comments · Fixed by #2609
Closed
3 of 5 tasks

Make gRPC downloads cancelable by complying to context.Context done signaling. #2595

cmaglie opened this issue May 6, 2024 · 0 comments · Fixed by #2609
Assignees
Labels
conclusion: resolved Issue was resolved topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project

Comments

@cmaglie
Copy link
Member

cmaglie commented May 6, 2024

Describe the request

A download is currently not cancelable. This is not a big problem in the standalone CLI app, since it can be forcibly terminated with a CTRL-C, it may be a bigger problem using gRPC because if a download-triggering call is closed or canceled, the underlying download is not stopped.

To achieve this feature two tasks are needed:

  • adding the possibility to inject a context in the Downloader library.
  • pass the actual context from the upper call levels to the download library.

Describe the current behavior

A download is not stopped if the gRPC call that caused it is canceled.

Arduino CLI version

nightly

Operating system

N/A

Operating system version

N/A

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the nightly build
  • My request contains all necessary details
@cmaglie cmaglie added type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project topic: gRPC Related to the gRPC interface and removed type: enhancement Proposed improvement labels May 6, 2024
@cmaglie cmaglie added this to the Arduino CLI v1.0.0 milestone May 6, 2024
@per1234 per1234 added the conclusion: resolved Issue was resolved label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: gRPC Related to the gRPC interface type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants