Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some warnings from the package #5

Closed
adheegm opened this issue Oct 16, 2022 · 5 comments
Closed

Some warnings from the package #5

adheegm opened this issue Oct 16, 2022 · 5 comments
Assignees

Comments

@adheegm
Copy link

adheegm commented Oct 16, 2022

Hello @arddluma

The package return these kind of warnings

  1. Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: arddluma/cloudflare-pages-slack-notification
    image

  2. The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
    image

Seems like need to update @action/core to the latest version actions/setup-node#590 actions/setup-node#589

@amitkoth
Copy link

amitkoth commented Oct 17, 2022

@arddluma echoing this above :) Really appreciate your help

@arddluma
Copy link
Owner

arddluma commented Oct 17, 2022

hey @adheegm ,
Thanks for reporting this, I will fix this soon and let you know.

@arddluma arddluma self-assigned this Oct 17, 2022
@arddluma
Copy link
Owner

hey @adheegm @amitkoth,
I have just pushed a fix for this, please update the version to 2.5 arddluma/cloudflare-pages-slack-notification@v2.5
In case Node.js 12 warning is not removed you may have to update actions/checkout to v3 actions/checkout@v3
Please let me know if fix works.
Thanks guys!

@adheegm
Copy link
Author

adheegm commented Oct 18, 2022

@arddluma Thanks so much - We don't see any warning anymore. Closing this ticket cc @amitkoth

@adheegm adheegm closed this as completed Oct 18, 2022
@amitkoth
Copy link

Awesome, thanks @arddluma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants