Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivy k8s: --disable-node-collector flag #6194

Closed
Tracked by #5745
chen-keinan opened this issue Feb 25, 2024 · 2 comments · Fixed by #6311
Closed
Tracked by #5745

trivy k8s: --disable-node-collector flag #6194

chen-keinan opened this issue Feb 25, 2024 · 2 comments · Fixed by #6311
Assignees
@chen-keinan
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning
Milestone
v0.51.0

Comments

@chen-keinan
Copy link
Contributor

chen-keinan commented Feb 25, 2024 •
edited

it is require to introduce a new flag --disable-node-collector
when the flag is in use trivy will not run node-collector job and the scan result will not present misconfiguration finding from inside the Node

  • when the flag is not in use the node-collector job will not be executed and the scan result will not present misconfiguration finding from inside the Node

  • remove old --components flag as it cannot operate in conjunction with this flag
@chen-keinan chen-keinan added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning labels Feb 25, 2024
This was referenced Feb 25, 2024
Open
Closed
@chen-keinan chen-keinan changed the title trivy k8s --intrusive flag trivy k8s: --intrusive flag Feb 26, 2024
@chen-keinan chen-keinan mentioned this issue Mar 13, 2024
Merged
4 tasks
@chen-keinan chen-keinan added this to the v0.51.0 milestone Mar 13, 2024
@chen-keinan chen-keinan changed the title trivy k8s: --intrusive flag trivy k8s: --non-intrusive flag Mar 14, 2024
@chen-keinan chen-keinan changed the title trivy k8s: --non-intrusive flag trivy k8s: --skip-intrusive flag Mar 17, 2024
@knqyf263
Copy link
Collaborator

The default is running node-collector. Is it okay for you? @itaysk

@chen-keinan
Copy link
Contributor Author

The default is running node-collector. Is it okay for you? @itaysk

@knqyf263 yes, node-collector will run by default, see use-cases table here: #5745

@chen-keinan chen-keinan changed the title trivy k8s: --skip-intrusive flag trivy k8s: --non-intrusive flag Apr 2, 2024
@chen-keinan chen-keinan changed the title trivy k8s: --non-intrusive flag trivy k8s: --disable-node-collector flag Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chen-keinan chen-keinan

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning
Projects
Trivy Roadmap
Archived in project
Milestone
v0.51.0
Development

Successfully merging a pull request may close this issue.

BREAKING: add support for k8s disable-node-collector flag chen-keinan/trivy
2 participants
@knqyf263 @chen-keinan