Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): Improve misconfig scan messaging #6307

Closed
wants to merge 1 commit into from
Closed

fix(misconf): Improve misconfig scan messaging #6307

wants to merge 1 commit into from

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Mar 12, 2024

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 requested a review from nikpivkin March 12, 2024 19:10
nikpivkin
nikpivkin reviewed Mar 13, 2024
View reviewed changes
pkg/scanner/local/scan.go
@@ -222,7 +222,7 @@ func (s Scanner) misconfsToResults(misconfs []ftypes.Misconfiguration, options t

// MisconfsToResults is exported for trivy-plugin-aqua purposes only
func (s Scanner) MisconfsToResults(misconfs []ftypes.Misconfiguration) types.Results {
log.Logger.Infof("Detected config files: %d", len(misconfs))
log.Logger.Infof("Detected files with misconfig: %d", len(misconfs))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is correct to say that files with misconfig are detected, because the list of misconfigurations may only contain successfully passed checks.

@simar7
Copy link
Member Author

simar7 commented Apr 28, 2024

I think we should address this when we update IaC logging to use slog.

@simar7 simar7 closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin left review comments

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 will be requested when the pull request is marked ready for review knqyf263 is a code owner

@DmitriyLewen DmitriyLewen Awaiting requested review from DmitriyLewen DmitriyLewen will be requested when the pull request is marked ready for review DmitriyLewen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(misconf): Improve scan results messaging
2 participants
@simar7 @nikpivkin