Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Scan tarred helm dependencies #2857

Merged
merged 1 commit into from Sep 12, 2022
Merged

fix: Scan tarred helm dependencies #2857

merged 1 commit into from Sep 12, 2022

Conversation

owenrumney
Copy link
Contributor

@owenrumney owenrumney commented Sep 12, 2022 •
edited

Helm scanning was not correctly unpacking dependencies tars to the right place. This is fixed in defsec

Signed-off-by: Owen Rumney owen.rumney@aquasec.com

Description

Related issues

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

fix: Scan tarr'd dependencies
eac0bee 
Helm scanning was not correctly unpacking dependencies tars to the right
place. This is fixed in defsec

Resolves #2850

Signed-off-by: Owen Rumney <owen.rumney@aquasec.com>
@owenrumney owenrumney changed the title fix: Scan tarr'd dependencies fix: Scan tarred helm dependencies Sep 12, 2022
@owenrumney owenrumney marked this pull request as ready for review September 12, 2022 09:42
@knqyf263 knqyf263 merged commit 2f37961 into main Sep 12, 2022
@knqyf263 knqyf263 deleted the owenr=2850-helm-subcharts branch September 12, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trivy config scanning does not detect tar'ed dependency Helm charts
2 participants
@owenrumney @knqyf263