Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic links support for scan results #2838

Merged

Conversation

chen-keinan
Copy link
Contributor

@chen-keinan chen-keinan commented Sep 7, 2022

Signed-off-by: chenk hen.keinan@gmail.com

Description

dynamic links support for scan results

Related issues

Checklist

Signed-off-by: chenk <hen.keinan@gmail.com>
@knqyf263
Copy link
Collaborator

knqyf263 commented Sep 7, 2022

Don't we generate an AVD page for outdated API? When do we want to use rego.Metadata.url instead of AVD URL?

@chen-keinan
Copy link
Contributor Author

chen-keinan commented Sep 14, 2022

Don't we generate an AVD page for outdated API? When do we want to use rego.Metadata.url instead of AVD URL?

@knqyf263 in this case the link must be dynamic as its different from one result to another ,so not avd page , we use rego.Metadata.url only when it is custom (not built in policy) and the AVD URL is empty

@chen-keinan chen-keinan mentioned this pull request Sep 14, 2022
2 tasks
@knqyf263
Copy link
Collaborator

Can you please give me an example of the link? What does the link look like?

@knqyf263 knqyf263 merged commit b677d7e into aquasecurity:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic links support on config scan results
2 participants