Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(report): add secrets to sarif format #2820

Merged
merged 3 commits into from Sep 12, 2022
Merged

feat(report): add secrets to sarif format #2820

merged 3 commits into from Sep 12, 2022

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Sep 2, 2022 •
edited

Description

Added secret to sarif format.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen mentioned this pull request Sep 2, 2022
Closed
@DmitriyLewen DmitriyLewen marked this pull request as ready for review September 2, 2022 09:57
@knqyf263 knqyf263 requested a review from afdesk September 4, 2022 09:09
@knqyf263
Copy link
Collaborator

knqyf263 commented Sep 7, 2022

@afdesk Did you confirm it worked? Can we merge it?

@afdesk
Copy link
Contributor

afdesk commented Sep 7, 2022

@knqyf263 no, let me check it with our demo repository

@afdesk
Copy link
Contributor

afdesk commented Sep 8, 2022

@knqyf263 checked. it seems it works correctly: https://github.com/afdesk/sarif-test/security/code-scanning/537

@knqyf263 knqyf263 merged commit acb65d5 into main Sep 12, 2022
@knqyf263 knqyf263 deleted the feat/secret_in_sarif branch September 12, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

@afdesk afdesk afdesk approved these changes

Assignees

@afdesk afdesk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent report between the SARIF and JSON format
3 participants
@DmitriyLewen @knqyf263 @afdesk