Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm): helm test with ingress #2630

Merged
merged 2 commits into from Sep 12, 2022

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Jul 30, 2022

Description

  • Update versions in the publish-chart gh
  • Update the ingress test flag in publish-chart gh
  • Disabled the PodSecurtyPolicy by default

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@krol3 krol3 requested a review from knqyf263 as a code owner July 30, 2022 18:33
@knqyf263
Copy link
Collaborator

knqyf263 commented Aug 1, 2022

The title needs to follow the convention.
https://aquasecurity.github.io/trivy/v0.30.4/community/contribute/pr/#title

@krol3 krol3 changed the title chore (gh): helm test with ingress chore (helm): helm test with ingress Sep 7, 2022
@krol3 krol3 changed the title chore (helm): helm test with ingress chore(helm): helm test with ingress Sep 7, 2022
@krol3
Copy link
Contributor Author

krol3 commented Sep 7, 2022

The title needs to follow the convention. https://aquasecurity.github.io/trivy/v0.30.4/community/contribute/pr/#title

Nice checking about the title!

@knqyf263 knqyf263 merged commit db14ef3 into aquasecurity:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants