Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move osinfo logic into tracee (or expand it in libbpfgo ?) #297

Open
rafaeldtinoco opened this issue Mar 1, 2023 · 5 comments
Open

move osinfo logic into tracee (or expand it in libbpfgo ?) #297

rafaeldtinoco opened this issue Mar 1, 2023 · 5 comments
Assignees

Comments

@rafaeldtinoco
Copy link
Contributor

I think OSinfo logic is only used by tracee and, it is not part of libbpf nor interesting to be kept inside libbpfgo (IMO). What do you think @geyslan ? We could create a pkg there and get rid of the helper:

https://github.com/aquasecurity/libbpfgo/blob/main/helpers/osinfo.go

from here. It would be easier to expand that pkg there, while removing the code footprint here.

WDYT ?

@rafaeldtinoco rafaeldtinoco added this to the next-feature-milestone milestone Mar 1, 2023
@yanivagman
Copy link
Collaborator

This can be a good idea, but we better verify that the users of libbpfgo really don't use it.
We can open a discussion about that to see if there are any objections

@yanivagman
Copy link
Collaborator

yanivagman commented Mar 5, 2023

Actually, we can copy the packages into tracee (including helpers?) and write a comment that it is deprecated in libbpfgo, and whoever wants it can use the package from Tracee, WDYT?

@rafaeldtinoco
Copy link
Contributor Author

Yep, good idea, lets deprecate it in libbpfgo for one or two releases and move it into tracee!

@rafaeldtinoco rafaeldtinoco self-assigned this Mar 6, 2023
@geyslan
Copy link
Member

geyslan commented Mar 6, 2023

Yep, good idea, lets deprecate it in libbpfgo for one or two releases and move it into tracee!

+1

Actually, we can copy the packages into tracee (including helpers?) and write a comment that it is deprecated in libbpfgo, and whoever wants it can use the package from Tracee, WDYT?

I think we have a current difficulty in maintaining different packages inside tracee, for example it's laborious to make changes in types. We just avoided turning pkg/logger into a pkg of its own by thinking about that trouble, what resulted in a three layer callback.

I guess @NDStrahilevitz has thoughts concerning that as well.

@rafaeldtinoco
Copy link
Contributor Author

I think we have a current difficulty in maintaining different packages inside tracee, for example it's laborious to make changes in types.

I thought about the multi-packaged tracee (pkg/xxx) package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants