New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move osinfo logic into tracee (or expand it in libbpfgo ?) #297
Comments
This can be a good idea, but we better verify that the users of libbpfgo really don't use it. |
Actually, we can copy the packages into tracee (including helpers?) and write a comment that it is deprecated in libbpfgo, and whoever wants it can use the package from Tracee, WDYT? |
Yep, good idea, lets deprecate it in libbpfgo for one or two releases and move it into tracee! |
+1
I think we have a current difficulty in maintaining different packages inside tracee, for example it's laborious to make changes in I guess @NDStrahilevitz has thoughts concerning that as well. |
I thought about the multi-packaged tracee (pkg/xxx) package. |
I think OSinfo logic is only used by tracee and, it is not part of libbpf nor interesting to be kept inside libbpfgo (IMO). What do you think @geyslan ? We could create a pkg there and get rid of the helper:
https://github.com/aquasecurity/libbpfgo/blob/main/helpers/osinfo.go
from here. It would be easier to expand that pkg there, while removing the code footprint here.
WDYT ?
The text was updated successfully, but these errors were encountered: