New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement API for checking if map and program types are supported #164
Conversation
May we have a selftest for Bpf program types as well ? |
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
93e04ac
to
d29f9c2
Compare
Anything for you Rafael |
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
Reviewing this now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There is a minor alignment issue you can fix before merging.
selftest/probe-features/main.bpf.c
Outdated
SEC("kprobe/sys_mmap") | ||
int kprobe__sys_mmap(struct pt_regs *ctx) | ||
{ | ||
bpf_printk("Yankees will win the 2022 world series"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unaligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
important: needs a baseball fan review, let's block this until then.
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
Signed-off-by: grantseltzer grantseltzer@gmail.com