Add strict mode API #160
Add strict mode API #160
Conversation
javierhonduco
force-pushed
the
add-strict-mode-api
branch
2 times, most recently
from
222261b
to
96eb304
Compare
javierhonduco
force-pushed
the
add-strict-mode-api
branch
from
96eb304
to
f0722d3
Compare
|
Addressed review feedback + added some more strict mode values |
See https://github.com/libbpf/libbpf/wiki/Libbpf-1.0-migration-guide for context. Related to aquasecurity#159
javierhonduco
force-pushed
the
add-strict-mode-api
branch
from
f0722d3
to
9dab898
Compare
|
Addressed feedback |
| } | ||
|
|
||
| func SetStrictMode(mode LibbpfStrictMode) { | ||
| C.libbpf_set_strict_mode(uint32(mode)) |
There was a problem hiding this comment.
| C.libbpf_set_strict_mode(uint32(mode)) | |
| C.libbpf_set_strict_mode(C.uint(mode)) |
There was a problem hiding this comment.
Last thing, then good to merge 👍
There was a problem hiding this comment.
Adding this errors with:
../libbpfgo/libbpfgo.go:365:27: cannot use _Ctype_uint(mode) (value of type _Ctype_uint) as type uint32 in argument to (_Cfunc_libbpf_set_strict_mode)
Seems like uint32 is the right type 😄. Passing a "Go" type seems recurrent for enums. I tried searching for this behaviour, but my Google-fu failed me
https://github.com/aquasecurity/libbpfgo/blob/main/libbpfgo.go#L1158-L1160
There was a problem hiding this comment.
That's so strange, I can in fact reproduce that.
I did some googling and apparently enums are simplified to uint32's in CGO wrappers. This issue isn't the same as ours specifically, but it does mention this. Learn something new everyday :-)
See https://github.com/libbpf/libbpf/wiki/Libbpf-1.0-migration-guide for context.
Related to #159
cc/ @Sylfrena @kakkoyun @v-thakkar