Add helpers for passing flags #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libbpfgo.go
Outdated
| @@ -841,6 +861,14 @@ func (b *BPFMap) Update(key, value unsafe.Pointer) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (b *BPFMap) UpdateFlags(key, value unsafe.Pointer, flags MapFlag) error { | |||
There was a problem hiding this comment.
The function name makes it look like it is updating the "flags" for a map, while actually we're just updating the map using flags argument. Should we change the method name ?
I think I'm ok with not breaking the API to have flags added, at least until we decide to break the API and unify those 2 (should we add a TODO at the code ?). Also, we could make Update() be a call to UpdateFlags() (with a new name) with a nil flag argument (something like libbpf does when deprecating functions).
rafaeldtinoco
suggested changes
Jun 24, 2022
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
grantseltzer
force-pushed
the
update-lookup-flags-helpers
branch
from
ec44380
to
51ece12
Compare
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
grantseltzer
force-pushed
the
update-lookup-flags-helpers
branch
from
5737fd9
to
42e5405
Compare
|
Good thinking, I've updated accordingly. |
rafaeldtinoco
approved these changes
Jun 24, 2022
|
I hate merging so much, that was an accident. It'l never happen again, I promise you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bpf helper
bpf_map_update_elemtakes a flags parameter which we're not letting users specify. Instead of breaking the API, i've added another helper for it. Additionally I've added API for thebpf_map_lookup_elem_flagshelper.Signed-off-by: grantseltzer grantseltzer@gmail.com