VersionString() API selftest #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantseltzer
force-pushed
the
version-selftest
branch
from
22e9bd0
to
d992a04
Compare
kakkoyun
previously approved these changes
Mar 17, 2022
selftest/version/main.go
Outdated
| @@ -0,0 +1,28 @@ | |||
| package main | |||
|
|
|||
| import "C" | |||
There was a problem hiding this comment.
we dont need import C here.
selftest/version/main.go
Outdated
|
|
||
| // libbpf doesn't put the patch version in exported version | ||
| // symbols, so use just prefix to exclude it | ||
| if strings.HasPrefix(libbpfgo.VersionString(), string(b)) { |
There was a problem hiding this comment.
When I first read libbpfgo.VersionString() I thought we were comparing libbpf version with libbpfgo version (to see if libbpf string was contained in libbpfgo string). Should we change "VersionString" name ?
rafaeldtinoco
previously approved these changes
Jun 24, 2022
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
grantseltzer
dismissed stale reviews from rafaeldtinoco and kakkoyun
via
2fe4c81
grantseltzer
force-pushed
the
version-selftest
branch
from
d992a04
to
2fe4c81
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAQ
Is this the most useful selftest? No.
Is it good to have? ok.
Signed-off-by: grantseltzer grantseltzer@gmail.com