Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seiso should fail the pipeline on errors #30

Open
bittner opened this issue Jun 29, 2020 · 0 comments
Open

Seiso should fail the pipeline on errors #30

bittner opened this issue Jun 29, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@bittner
Copy link
Contributor

bittner commented Jun 29, 2020

Currently, when seiso fails on certain errors the pipeline, e.g. on GitLab, succeeds happily.

Instead, it should fail and make the pipeline error out, as we would expect it to do.

Examples

On Git-related errors (corrupted file system or Git history):

 $ seiso image history ${IMAGE_NAME} --keep 15 --delete
Error: retrieving commit hashes failed: object not found

On Kubernetes integration issues (unknown namespace as GitLab chooses it automatically when not specified):

 $ seiso image history ${IMAGE_NAME} --keep 15 --delete
Error: could not retrieve image stream 'foo-9-integration/myimage': imagestreams.image.openshift.io "myimage" is forbidden: User "system:serviceaccount:some-foo-production:gitlab-ci" cannot get imagestreams.image.openshift.io in the namespace "foo-9-integration": no RBAC policy matched
@bittner bittner added the bug Something isn't working label Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant