Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'blockUntilReporterExits' of undefined #124

Open
DanKaplanSES opened this issue Sep 21, 2021 · 3 comments
Open

Cannot read property 'blockUntilReporterExits' of undefined #124

DanKaplanSES opened this issue Sep 21, 2021 · 3 comments

Comments

@DanKaplanSES
Copy link

I receive this error when I follow the mocha example. I have made a PR to solve the problem, but I believe the source of the issue is approvals\lib\Providers\BeforeEachVerifierBase.js It's call to FileApprover.verify(namer, writer, reporterFactory); doesn't pass in any options and GenericDiffReporterBase.report (and other reporters) are written as if it did.

@DanKaplanSES
Copy link
Author

sorry I don't know how to link to a PR. This is my attempt: #123

@claremacrae
Copy link
Contributor

Thank you for logging this. I am getting this problem too.

@claremacrae
Copy link
Contributor

I found a workaround for this, which was to revert from 4.0.0-beta.1 to 3.0.5

So using this in package.json:

    "approvals": "^3.0.5",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants