Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Example use cases with verify_sql in README #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trevorturk
Copy link

@trevorturk trevorturk commented Nov 14, 2022

Description

Closes #91

Adds an "Example use cases" section to the README with an example verify_sql Rspec helper for use in Rails apps with complex SQL queries.

I was searching for the old code sample from this issue: #91 and thought it worth trying to write something up in the docs so it's easy (for me) to find (lol) next time.

Please feel free to discard, or perhaps consider opening the wiki or discussions if it might be better to post stuff like this somewhere else. (Apologies, it looks like you're trying to keep the README small, so I feel bad even proposing this!)

@geeksam
Copy link
Contributor

geeksam commented Nov 19, 2022

Hello, and thank you! Katrina handed this gem off to @isidore and me earlier this year. Any terseness you see in the README is from years ago; I, for one, am a big fan of verbose READMEs. :)

We've both been super busy, but I wanted to let you know I'd seen this, and I hope to get to it soon...ish...

@trevorturk
Copy link
Author

No worries at all, and don't worry if you prefer to handle this some other way (or not!) I'm just a fan of this idea and wish more people knew about it, especially when using GraphQL it's very handy. Thanks again in any case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using approvals to verify_sql
2 participants