Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericDiffReporter __init__ takes a tuple - quite annoying #80

Open
objarni opened this issue Dec 5, 2020 · 0 comments
Open

GenericDiffReporter __init__ takes a tuple - quite annoying #80

objarni opened this issue Dec 5, 2020 · 0 comments

Comments

@objarni
Copy link
Contributor

objarni commented Dec 5, 2020

I think the GenericDiffReporter should just take two arguments, not a tuple. Saves a lot of dev.time worldwide :)

Update: It would be possible to be backwards-compatible by using the *arguments syntax, and then go different paths depending on the length of that list:

 if len(arguments) == 1:
    # Old code here
 else:
    # New code here

.. but I'm not sure it's worth the hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant